Repository navigation
Conversation
(Plot image upload to picrd.com failed; download the artifact below to view plots) Generated via commit 1191afa Download link for the artifact containing the test results: ↓ atime-results.zip
|
tdhock
added
the
atime
tdhock
commented
Oct 24, 2026
Comment on lines
+337
to
+347
| bisect.commits=c( | ||
| Before4164 = "166e0bab317e9d9f4f1844997a315e6482ab5fd9",#a few click of parent up from first commit in PR4164 gets to https://github.com/Rdatatable/data.table/commit/166e0bab317e9d9f4f1844997a315e6482ab5fd9 | ||
| PR4164="4aadde8f5a51cd7c8f3889964e7280432ec65bbc", # Merge commit of the PR that causes the regression. | ||
| Parent4558="6f360be0b2a6cf425f6df751ca9a99ec5d35ed93", #parent of PR4558 (https://github.com/Rdatatable/data.table/commit/ba32f3cba38ec270587e395f6e6c26a80be36be6) | ||
| PR4558 = "ba32f3cba38ec270587e395f6e6c26a80be36be6", # Merge commit of the PR (https://github.com/Rdatatable/data.table/pull/4558) that fixes the regression | ||
| Parent4491="3fa8b20435d33b3d4b5c26fd9b0ac14c10b98800", # PR4491 is bisect result of PR4164 and Parent5463. | ||
| PR4491="85adf09e3463838d547977ae9bc75e3b37f9cbaf", | ||
| Parent5463="052f8da6", # PR5463 is bisect result of PR4164 and Parent7401. | ||
| PR5463="19b7866112614db53eb3e909c097407d91cd6738", | ||
| Parent7401="20b463c9592c07d05ad2e89a25f84f0b998d6154", # master parent of the PR7401 which caused the recent speedup. | ||
| Fast="a3eeb4c0caec51afd66bdf9bbc16817e12a47a40"), #master 10 Sept 2026 |
Member
Author
There was a problem hiding this comment.
these commits can be used with atime::bisect() but do not appear in the CI results:
tdhock
marked this pull request as ready for review
October 24, 2026 14:17
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds historical commits using new git bisect functionality in tdhock/atime#131
Like #7688 but more automated.
Visualization of results here https://tdhock.github.io/2026-10-13-bisect-performance-pr7912/ shows that #4491 also slowed down this test case (not yet documented in atime test case), in addition to #4164 (already documented as the Regression commit in atime test case).
